Skip to content

[Aikido] AI Fix for Possible command injection via Process.Start #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aikido-autofix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Aikido] AI Fix for Possible command injection via Process.Start #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/Servers/IIS/IntegrationTesting.IIS/src/IISExpressDeployer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,9 @@ private string CheckIfPublishIsRequired()
Logger.LogInformation("Attempting to start IIS Express on port: {port}", port);
PrepareConfig(contentRoot, port);

var parameters = string.IsNullOrEmpty(DeploymentParameters.ServerConfigLocation) ?
string.Format(CultureInfo.InvariantCulture, "/port:{0} /path:\"{1}\" /trace:error /systray:false", uri.Port, contentRoot) :
string.Format(CultureInfo.InvariantCulture, "/site:{0} /config:{1} /trace:error /systray:false", DeploymentParameters.SiteName, DeploymentParameters.ServerConfigLocation);

Logger.LogInformation("Executing command : {iisExpress} {parameters}", iisExpressPath, parameters);

var startInfo = new ProcessStartInfo
{
FileName = iisExpressPath,
Arguments = parameters,
UseShellExecute = false,
CreateNoWindow = true,
RedirectStandardError = true,
Expand All @@ -185,6 +178,23 @@ private string CheckIfPublishIsRequired()
WorkingDirectory = Path.GetDirectoryName(iisExpressPath)
};

if (string.IsNullOrEmpty(DeploymentParameters.ServerConfigLocation))
{
startInfo.ArgumentList.Add("/port:" + uri.Port.ToString(CultureInfo.InvariantCulture));
startInfo.ArgumentList.Add("/path:" + contentRoot);
startInfo.ArgumentList.Add("/trace:error");
startInfo.ArgumentList.Add("/systray:false");
}
else
{
startInfo.ArgumentList.Add("/site:" + DeploymentParameters.SiteName);
startInfo.ArgumentList.Add("/config:" + DeploymentParameters.ServerConfigLocation);
startInfo.ArgumentList.Add("/trace:error");
startInfo.ArgumentList.Add("/systray:false");
}

Logger.LogInformation("Executing command : {iisExpress} {parameters}", iisExpressPath, string.Join(" ", startInfo.ArgumentList));

AddEnvironmentVariablesToProcess(startInfo, DeploymentParameters.EnvironmentVariables);

Uri url = null;
Expand Down