fix(agent-ui): reset streamed text at generation boundaries in agent chat#10664
Open
walcz-de wants to merge 1 commit into
Open
fix(agent-ui): reset streamed text at generation boundaries in agent chat#10664walcz-de wants to merge 1 commit into
walcz-de wants to merge 1 commit into
Conversation
…chat One agent turn runs several internal LLM generations (tool selection, reasoning, final answer) that all emit stream_event deltas over the same per-agent SSE channel. The chat page accumulated every 'content' delta into a single live bubble and ignored the 'done' boundary events, so the internal generations' text (e.g. the English tool-selection rationale) merged with — and visually corrupted — the streamed final answer. Reset the accumulated content/reasoning on 'done': each generation gets a clean live bubble, and the authoritative full answer still arrives via the final json_message event as before. Signed-off-by: Stefan Walcz <stefan.walcz@walcz.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One agent turn runs several internal LLM generations (tool selection, reasoning, final answer) that all emit
stream_eventdeltas over the same per-agent SSE channel. The agent chat page accumulates everycontentdelta into a single live bubble and ignores thedoneboundary events — so the internal generations' text (e.g. the English tool-selection rationale) merges with, and visually corrupts, the streamed final answer.Fix
Reset the accumulated content/reasoning when a
donestream event arrives: each generation gets a clean live bubble. The authoritative full answer still arrives via the finaljson_messageevent exactly as before, so no information is lost.Related server-side ordering fix: mudler/LocalAGI#483 (SSE broadcast worker pool scrambles delta order).
🤖 Generated with Claude Code
https://claude.ai/code/session_01KYp5FnAfsdGb6yjLmv8Mge