fix typo in cbanmanager#4920
Open
WUBE1234 wants to merge 2 commits into
Open
Conversation
used == instead of comma in GetBansWithBanner
Member
|
There are other changes here which you've not mentioned above. Why is the code removed? |
Author
|
my bad, messed up during copy-paste in the browser editor and didn't notice the file got truncated at the end. i'll revert the accidental deletions right away and push only the intended lookups fix. sorry about that. |
reverted the unintended code removal from previous commit, file is complete now
Contributor
|
Your last commit didn't change anything at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usfixed a typo in GetBansWithBanner
Summary
comma operator was used instead of ==, fixing it now
Motivation
GetBansWithBanner lookup was broken because of the typo
Test plan
just syntax fix, safe to merge
Checklist