Websockets Implementation for the Connecting screen#310
Open
codingLogan wants to merge 7 commits intomasterfrom
Open
Websockets Implementation for the Connecting screen#310codingLogan wants to merge 7 commits intomasterfrom
codingLogan wants to merge 7 commits intomasterfrom
Conversation
Collaborator
Author
|
Recent Test Runs With the new feature enabled With the new feature disabled |
wesrisenmay-mx
approved these changes
Apr 16, 2026
Collaborator
|
Looks good if you take out the ADR change, or get most of the team onboard with the ADR change |
ash-wright123
approved these changes
Apr 16, 2026
Collaborator
Author
|
Update - The one failing test now passes. The websocket server now has the ability to forward along actionable error details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works
The hosting app does a lot of the heavy lifting and passes in what is required by the UI
How to pass the values into the UI package
In the hosting app, pass in a new prop object to the ConnectWidget named
webSocketConnectionTo enable the widget to use those values, you must also enable the
useWebSocketsexperimental feature