Skip to content

fix #333: pass agent card query parameters correctly - #334

Merged
Sunrisea merged 1 commit into
nacos-group:masterfrom
Sunrisea:codex/fix-333-agent-card-params
Jul 30, 2026
Merged

fix #333: pass agent card query parameters correctly#334
Sunrisea merged 1 commit into
nacos-group:masterfrom
Sunrisea:codex/fix-333-agent-card-params

Conversation

@Sunrisea

Copy link
Copy Markdown
Member

Summary

  • preserve GetAgentCardParam.version and registration_type when querying an Agent Card
  • use explicit keyword arguments when forwarding the request to the gRPC proxy
  • add a focused regression test for the parameter mapping

Root cause

NacosAIService.get_agent_card() passed registration_type in the proxy's version position and version in the registration_type position. Queries that specified either field therefore generated an incorrect QueryAgentCardRequest.

Test plan

  • python -m unittest test.test_nacos_ai_service test.test_skill_and_prompt test.test_client_config_builder test.test_naming_service_cache
  • ruff check --select F --ignore F401 --exclude '*/grpcauto/*' v2/ test/test_nacos_ai_service.py
  • python -m compileall -q v2/nacos/ai test/test_nacos_ai_service.py
  • git diff --check

Closes #333

@Sunrisea
Sunrisea marked this pull request as ready for review July 30, 2026 09:44
@Sunrisea
Sunrisea merged commit d19e09d into nacos-group:master Jul 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] get_agent_card passes version and registration_type in the wrong order

1 participant