fix #333: pass agent card query parameters correctly - #334
Merged
Sunrisea merged 1 commit intoJul 30, 2026
Conversation
Sunrisea
marked this pull request as ready for review
July 30, 2026 09:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetAgentCardParam.versionandregistration_typewhen querying an Agent CardRoot cause
NacosAIService.get_agent_card()passedregistration_typein the proxy'sversionposition andversionin theregistration_typeposition. Queries that specified either field therefore generated an incorrectQueryAgentCardRequest.Test plan
python -m unittest test.test_nacos_ai_service test.test_skill_and_prompt test.test_client_config_builder test.test_naming_service_cacheruff check --select F --ignore F401 --exclude '*/grpcauto/*' v2/ test/test_nacos_ai_service.pypython -m compileall -q v2/nacos/ai test/test_nacos_ai_service.pygit diff --checkCloses #333