chore: remove Slack custom emoji integration#150
Merged
Conversation
The SLACK_TOKEN is inactive (account_inactive error). Remove: - remark-custom-emojis.js plugin - @slack/web-api and node-emoji dependencies - SLACK_TOKEN from deploy workflow - Related docs in README.md and AGENTS.md Custom Slack emojis in markdown (:naisely-done:, :texas:) will now render as plain text.
- :naisely-done: → ✅ - :texas: → 🤠
There was a problem hiding this comment.
Pull request overview
Removes the build-time Slack custom emoji integration from this SvelteKit/mdsvex static site, since the SLACK_TOKEN is no longer usable and the feature is low value.
Changes:
- Removed the
remark-custom-emojis.jsremark plugin and its usage insvelte.config.js. - Removed Slack-related dependencies and
SLACK_TOKENusage in the deploy workflow. - Updated repository docs to no longer mention Slack emoji setup.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
svelte.config.js |
Removes the custom emoji remark plugin from the mdsvex pipeline. |
remark-custom-emojis.js |
Deletes the Slack emoji fetching/rewriting implementation. |
package.json |
Drops Slack Web API and node-emoji dependencies (note: one unused dependency appears to remain). |
pnpm-lock.yaml |
Updates lockfile to reflect removed packages. |
README.md |
Removes local dev instructions related to Slack token/emoji access. |
AGENTS.md |
Removes references to the custom emoji plugin and Slack token requirement. |
.github/workflows/deploy.yml |
Removes SLACK_TOKEN secret injection during build. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SLACK_TOKENis inactive (account_inactiveerror during builds). Since the Slack app needs to be reinstalled and the custom emoji feature is low-value, removing the integration entirely.Removed:
remark-custom-emojis.js— remark plugin that fetched custom Slack emojis at build time@slack/web-apiandnode-emojidependencies (-44 packages)SLACK_TOKENsecret from deploy workflowImpact: Custom Slack emojis (
:naisely-done:,:texas:) in 3 log posts will render as plain text. Standard Unicode emojis are unaffected.