Conversation
…are no longer needed.
jmaeng72
previously approved these changes
Jun 19, 2026
jmaeng72
requested changes
Jun 19, 2026
jmaeng72
left a comment
Contributor
There was a problem hiding this comment.
If we are removing service-entry and service-option, we should delete all mention of them across all of cmr.
For example in schemas/README.md
Contributor
Author
|
I have updated 2 documents that contained the schema's by name. I used grep to search for service entry and service options using different variations and didn't find any other mentions of those schemas. |
jmaeng72
approved these changes
Jun 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2447 +/- ##
==========================================
- Coverage 58.20% 58.19% -0.02%
==========================================
Files 1069 1069
Lines 74278 74278
Branches 2165 2162 -3
==========================================
- Hits 43233 43223 -10
- Misses 29028 29035 +7
- Partials 2017 2020 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the objective?
removing service-entry and service-option schemas as they are no longer needed.
What are the changes?
removing service-entry and service-option schemas as they are no longer needed.
What areas of the application does this impact?
schemas
Required Checklist
Additional Checklist