Skip to content

CMR-10937: removing service-entry and service-option schemas as they are no longer needed.#2447

Open
eereiter wants to merge 2 commits into
masterfrom
CMR-10937
Open

CMR-10937: removing service-entry and service-option schemas as they are no longer needed.#2447
eereiter wants to merge 2 commits into
masterfrom
CMR-10937

Conversation

@eereiter

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

removing service-entry and service-option schemas as they are no longer needed.

What are the changes?

removing service-entry and service-option schemas as they are no longer needed.

What areas of the application does this impact?

schemas

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

jmaeng72
jmaeng72 previously approved these changes Jun 19, 2026
@jmaeng72 jmaeng72 dismissed their stale review June 19, 2026 14:20

requesting changes

@jmaeng72 jmaeng72 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are removing service-entry and service-option, we should delete all mention of them across all of cmr.

For example in schemas/README.md

@eereiter

Copy link
Copy Markdown
Contributor Author

I have updated 2 documents that contained the schema's by name. I used grep to search for service entry and service options using different variations and didn't find any other mentions of those schemas.

@codecov-commenter

codecov-commenter commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.19%. Comparing base (d304270) to head (c478f46).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2447      +/-   ##
==========================================
- Coverage   58.20%   58.19%   -0.02%     
==========================================
  Files        1069     1069              
  Lines       74278    74278              
  Branches     2165     2162       -3     
==========================================
- Hits        43233    43223      -10     
- Misses      29028    29035       +7     
- Partials     2017     2020       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants