CMR-10964 Change schemas to accommodate better collection quality information metadata#2448
Open
eereiter wants to merge 5 commits into
Open
CMR-10964 Change schemas to accommodate better collection quality information metadata#2448eereiter wants to merge 5 commits into
eereiter wants to merge 5 commits into
Conversation
jmaeng72
requested changes
Jun 19, 2026
| <action>changed</action> | ||
| <src>added mixed case to field with new fields with text and enum on 2026-01</src> | ||
| <since>10.2.g</since> | ||
| <note>If the sub-fields are used only the sub-fields should have text and there should be no text between the main field and sub-fields. Allow the user to add text to the main field if only the main field is used but no sub-fields should be used to define the quality.</note> |
Contributor
There was a problem hiding this comment.
This statement is confusing
|
|
||
| Example Usage: | ||
| * Associated_DOIs/Type = 'Other' | ||
| * Associcated_DOIs/Type = 'Other' |
Contributor
There was a problem hiding this comment.
why was this changed? Associated is spelled wrong in the new update
| (m-spec/update-version c :collection "1.18.5"))) | ||
|
|
||
| (defmethod interface/migrate-umm-version [:collection "1.18.5" "1.18.6"] | ||
| ;; Converts the 1.18.5 single string into the 1.18.6 QualityType's Summary." |
Contributor
There was a problem hiding this comment.
should you mention that QualityType Summary is a map? Such as you did with the above 1.18.16 > 1.18.5 translation
| ;; quality or quality flags - both validated or invalidated; 4) recognized or potential problems | ||
| ;; with quality; 5) established quality control mechanisms; and 6) established quantitative | ||
| ;; quality measurements. | ||
| ;; Elements describing quality of the collection data. The description may include: 1) Known |
Contributor
There was a problem hiding this comment.
can you put the list on new lines.
1)..
2)...
for easier readability
| "Returns the expected DOI." | ||
| [quality] | ||
| (when (:Summary quality) | ||
| (assoc quality :Summary (string/trim(:Summary quality))))) |
Contributor
There was a problem hiding this comment.
space between trim and (:Summary...
| [:S3CredentialsAPIEndpoint (:S3CredentialsAPIEndpoint direct-dist-info)] | ||
| [:S3CredentialsAPIDocumentationURL (:S3CredentialsAPIDocumentationURL direct-dist-info)]])])) | ||
| [:S3CredentialsAPIDocumentationURL (:S3CredentialsAPIDocumentationURL direct-dist-info)]]) | ||
| (generate-quality c)])) No newline at end of file |
| (let [doc "<Collection><Quality><Summary>Only summary here.</Summary></Quality></Collection>" | ||
| expected {:Summary "Only summary here."} | ||
| parsed (#'echo10/parse-echo10-xml test-context doc false)] | ||
| (is (= expected (:Quality parsed)))))) |
Contributor
There was a problem hiding this comment.
This PR was quite large. Was there any way you could have broken it down to smaller PRs for easier (and most likely higher quality) reviews?
| <Description>Some description</Description> | ||
| </Related_URL> | ||
| </DIF>")) | ||
|
|
Contributor
There was a problem hiding this comment.
I would make sure these tests actually run in our build
| {:URL (str "https://cdn.earthdata.nasa.gov/umm/collection/v" | ||
| umm-spec-versioning/current-collection-version), | ||
| :Name "UMM-C" | ||
| :Version umm-spec-versioning/current-collection-version})})))) No newline at end of file |
| [tag text]))))) | ||
|
|
||
| (defn parse-quality | ||
| "Parses the 1.18.6 Quality object tree out of the existing ECHO 10 XSD configuration." |
Contributor
There was a problem hiding this comment.
if we put the version num here, that means every version update we need to update this comment. I would remove the version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the objective?
New UMM-C version 1.18.6 to change the quality metadata field from a string to an object that contains more detailed information.
What are the changes?
Changed UMM-C, DIF 10, ECHO 10 schemas. Added translations to all of the supported schemas. Added migration up and down for UMM-C. created and updated tests.
What areas of the application does this impact?
UMM-C, DIF 10, ECHO 10, translations, UMM-C migrations. These fields are not searched so the changes do not include search or indexer code.
Required Checklist
Additional Checklist