Fix #485, download Zhang files without requiring Content-Length - #494
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Fix #485, download Zhang files without requiring Content-Length#494sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #485.
Use the streamed GET response for optional download-size metadata instead of requiring a HEAD
Content-Length. Share the transport between the Zhang database and LUT downloads, tolerate absent/invalid sizes, and close network/progress resources on every exit.Stage downloads beside the destination and publish only after the existing checksum matches. Interrupted, HTTP-failed, or checksum-failed downloads now leave existing files intact and remove their temporary file; checksum failures no longer leave an invalid database installed.
Validation
macOS arm64, Python 3.12.11:
python -m unittest Tests.test_filing -v: 12 tests passed, exercising both public download functions.Content-Length, with real checksum verification.KeyErrorbefore the fix.git diff --checkpassed.Add the offline suite to Application Testing before the existing sample-data tests. Full sensor processing, live multi-gigabyte downloads, and Windows/Linux execution were not run.
Contributor: Sylvester Kaczmarek, Personal. No third-party code added.