Fix #50: Update login from username to email - #57
Open
mdraza7544 wants to merge 1 commit into
Open
Conversation
The website login form no longer contains a username field; it now\nauthenticates with email + password. - config.properties: rename 'username' property to 'email' and point 'url'\n to the current login page (form now lives at ui.freecrm.com/login)\n- LoginPage: update locators to the live form (id=email, id=password,\n button[type=submit]); rename login() param un -> emailId\n- LoginPageTest/HomePageTest/ContactsPageTest: read 'email' property
Author
|
Issue #50 has been fixed. The login flow is now updated to use email instead of username, and the related login test is passing. No unrelated files or tests were changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #50.
The website login now uses an email instead of a username, so the existing login tests were failing.
Changes made:
I also tested the login flow and the login test is now passing.
I did not change any unrelated files or tests.