Feature/tab orb favicon - #18
Merged
Merged
Conversation
Replaces the blank grey square favicon placeholder with a geometric Orb inline SVG icon on: - New Tab (no URL loaded) - History, Bookmarks, Downloads internal-page tabs Real website tabs continue showing the site favicon from Google S2. Favicon load errors fall back to the Orb logo gracefully. Also moves public/tab.svg to src/renderer/assets/orb-logo.svg (proper electron-vite renderer asset location).
- Import orb-logo.svg via Vite ?url so the actual branded SVG is used instead of the custom inline geometric shape - Add .tab-orb-logo CSS: 14x14 flex-center matching .tab-fav dimensions so the logo aligns perfectly with tab text - Fix compact hover: .tab-orb-logo also fades out on hover alongside .tab-fav and .tab-fav-ph - Add SVG ?url type declaration to style-imports.d.ts so TypeScript accepts the Vite asset URL import - Favicon load error now hides the <img> and reveals Orb fallback
- Wrap tabs in a horizontal overflow-x-auto scroll region - Pin the 'New Tab' button to the right of the scroll region - Add mouse wheel horizontal scrolling support for tabs - Auto-scroll active tabs into view upon selection - Hide scrollbars completely via CSS to maintain sleek UI - Adjust compact mode to base width off the new scroll region
…pinned to corner - Wrap tab strip and new tab button in a flex-1 container - Remove flex-1 from scroll region to shrink to contents - Ensure new tab button aligns closely to the rightmost tab - Match Chrome responsive tab layout behavior
…t behavior - Replaced raw flex-basis with explicit JS width calculations based on available space. - Prevent tabs from instantly squishing to 28px due to container constraint conflicts. - Enforce a 72px minimum width before tabs start horizontally scrolling, mimicking Chrome. - Removed the legacy 28px compact mode entirely for a cleaner, unified tab strip.
- Removed permanent border and background from the new tab button. - Applied a circular 'rounded-full' background on hover matching Chrome. - Vertically centered the button relative to the tab strip for better alignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.