TASK: Symfony-based refactor#34
Open
kdambekalns wants to merge 12 commits into
Open
Conversation
The configuration of the bind providers lead to a lot of confusion so we replace those by the symfony/ldap component. This change is the first kickstart to a working setup with simplified configuration format. It also changes the way a user is authenticated from using a single filter to directly fetch an account to a query that first fetches a possible account and then uses the fetched 'dn' to authenticate the user. Additionaly a provider first pragmatic Neos backend provider is added.
BUGFIX: Reset roles before collecting new ones
TASK: Complete the refactoring to using symfony/yaml
# Conflicts: # Classes/Security/Authentication/Provider/LdapProvider.php # Classes/Service/BindProvider/ActiveDirectoryBind.php # composer.json
This commit imports the core migration log to the "extra" section of the composer manifest.
Contributor
|
Glad to see that my 5 year old code really might be merged one day 😅 |
Member
Author
|
In case someone wants to test this – I'll gladly raise version constraints and/or do other minor tweaks as needed… let me know! |
Member
Author
|
Well, no LDAP in use here, and it seems nowhere else, either. |
Member
|
@kdambekalns we are using this - I can test this PR! All the best - Sebastian |
Member
Author
|
Hi @skurfuerst – anything to report back yet? 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uss
symfony/ldapto do the heavy lifting.Thanks to @radmiraal and @ComiR for the actual work.