Add Spanish translations#197
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughAdds a complete Spanish resource file ChangesSpanish Localization and String Fixes
🎯 1 (Trivial) | ⏱️ ~5 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/src/main/res/values-es/strings.xml (2)
5-6: ⚡ Quick winUntranslated placeholder text in navigation header strings.
Lines 5–6 contain English placeholder text from the Android Studio template ("Android Studio" and "android.studio@android.com") that were not translated to Spanish. If these
nav_header_*strings are rendered in the UI, they should be translated for consistent localization.If these strings are actually used in the app UI, consider translating them:
- Line 5:
android.studio@android.com→ something likeusuario.netbird@example.com- Line 6:
Android Studio→Aplicación NetBirdor a suitable placeholderIf they are purely metadata and not rendered, this can be deferred or left as-is for consistency with the English
values/strings.xml.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/res/values-es/strings.xml` around lines 5 - 6, The nav header strings nav_header_title and nav_header_subtitle contain English template placeholders; update their values in the strings resource to Spanish translations (or appropriate app-specific placeholders) by replacing nav_header_title's value "Android Studio" with a Spanish label such as "Aplicación NetBird" (or your chosen app name) and replacing nav_header_subtitle's value "android.studio@android.com" with a Spanish/localized placeholder like "usuario.netbird@example.com"; ensure the updated text stays within the existing <string name="nav_header_title"> and <string name="nav_header_subtitle"> entries so localization is consistent.
70-70: Fix misspelled string resource keychange_server_success_cloe(cloe→close)
dialog_change_server_success.xmluses@string/change_server_success_icon,@string/change_server_success_title, and@string/change_server_success_desc(and the close button uses@android:string/ok), and there are no code/XML references to eitherchange_server_success_cloeorchange_server_success_close. So this won’t currently trigger a runtimeMissingResourceException, but the resource key is misspelled/unused—rename it inapp/src/main/res/values/strings.xmlandapp/src/main/res/values-es/strings.xmlto prevent future mismatches.🔧 Proposed fix
- <string name="change_server_success_cloe">Aceptar</string> + <string name="change_server_success_close">Aceptar</string>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/res/values-es/strings.xml` at line 70, Rename the misspelled string resource key change_server_success_cloe to change_server_success_close in the app's default and Spanish string resources (both strings.xml variants), and update any code or XML that references the old key to use change_server_success_close; ensure there are no duplicate keys after the rename and run a resource sync/clean to validate references.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/res/values-es/strings.xml`:
- Line 30: Rename the misspelled string resource keys and keep usages
consistent: change the key about_privacy_poliy to about_privacy_policy in all
strings.xml files where it appears and update the reference in
fragment_about.xml (the layout uses `@string/about_privacy_poliy`) to
`@string/about_privacy_policy`; for change_server_success_cloe, decide the
intended key (likely change_server_success_close) and if so rename the key in
both app/src/main/res/values/strings.xml and
app/src/main/res/values-es/strings.xml to change_server_success_close and update
any callers (there are currently no callers found, so ensure future usages use
the corrected name), or leave as-is if the original spelling was intentional.
---
Nitpick comments:
In `@app/src/main/res/values-es/strings.xml`:
- Around line 5-6: The nav header strings nav_header_title and
nav_header_subtitle contain English template placeholders; update their values
in the strings resource to Spanish translations (or appropriate app-specific
placeholders) by replacing nav_header_title's value "Android Studio" with a
Spanish label such as "Aplicación NetBird" (or your chosen app name) and
replacing nav_header_subtitle's value "android.studio@android.com" with a
Spanish/localized placeholder like "usuario.netbird@example.com"; ensure the
updated text stays within the existing <string name="nav_header_title"> and
<string name="nav_header_subtitle"> entries so localization is consistent.
- Line 70: Rename the misspelled string resource key change_server_success_cloe
to change_server_success_close in the app's default and Spanish string resources
(both strings.xml variants), and update any code or XML that references the old
key to use change_server_success_close; ensure there are no duplicate keys after
the rename and run a resource sync/clean to validate references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 13752723-ece9-41e9-902b-bc1a8c579f23
📒 Files selected for processing (1)
app/src/main/res/values-es/strings.xml
1 participant
Summary by CodeRabbit