Skip to content

Closes #642: Add missing test_bulk_update_objects_without_change_permission stub - #643

Merged
jnovinger merged 1 commit into
featurefrom
642-fix-bulk-update-test-stub
Aug 3, 2026
Merged

Closes #642: Add missing test_bulk_update_objects_without_change_permission stub#643
jnovinger merged 1 commit into
featurefrom
642-fix-bulk-update-test-stub

Conversation

@bctiemann

@bctiemann bctiemann commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Closes: #642

Summary

  • NetBox core split its single generic test_bulk_update_objects_with_permission method into two separately-named tests on 2026-07-08 (fixing #22617: editing objects via bulk import form requires the change permission, not just add). Both new methods carry the same csv_update_data requirement the old single method had.
  • The 5 view test classes in this repo (CustomObjectTypeViewTestCase, CustomObjectTypeFieldViewTestCase, CustomObjectViewTestCase, ComplexCustomObjectViewTestCase, ObjectFieldViewTestCase) only stub out the old method name as a no-op to suppress it, since dynamically generated Custom Object models do not fit the standard CSV-bulk-update test pattern (none of them define csv_update_data). The new method name is not covered by that stub, so it falls through to the real inherited implementation and raises NotImplementedError.
  • main already carries an equivalent fix (added incidentally in c7a6965, bundled with unrelated branching CI matrix work, and never ported to feature since the branches diverged before that commit landed). This PR ports just the 5 stub-method additions to feature.

Test plan

  • All 5 previously-failing test_bulk_update_objects_without_change_permission tests now pass.
  • Full test_views.py module run clean apart from 4 pre-existing, unrelated local-environment failures (netbox_branching importable but not enabled in this environment PLUGINS list -- confirmed identical on the unmodified base branch too).
  • ruff check clean.
  • Manually triggered the "Lint and tests" workflow directly on a clean feature checkout (no diff) to confirm this exact failure reproduces with zero netbox-custom-objects changes, isolating the cause to the NetBox core side. See issue feature branch CI fails: missing test_bulk_update_objects_without_change_permission stub #642 for the full root-cause writeup.

…ission stub

NetBox core split its single generic test_bulk_update_objects_with_permission
method into two separately-named tests on 2026-07-08 (fixing #22617:
editing via bulk import form requires the change permission, not just
add). Both carry the same csv_update_data requirement, but this repo's
5 view test classes only stubbed out the old method name to suppress
it (since dynamically generated Custom Object models don't fit the
standard CSV-bulk-update test pattern. The new method fell through to
the real inherited implementation and started failing the moment a
NetBox core checkout containing that commit was used.

main already carries an equivalent fix (added incidentally in c7a6965,
bundled with unrelated branching CI matrix work, and never ported to
feature). This ports just the 5 stub-method additions.
EOF
)
@bctiemann
bctiemann requested review from a team and jnovinger and removed request for a team August 3, 2026 00:53
@jnovinger
jnovinger merged commit 3df0919 into feature Aug 3, 2026
7 checks passed
@jnovinger
jnovinger deleted the 642-fix-bulk-update-test-stub branch August 3, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants