Skip to content

fix(thumbnail): generation for zip file #17171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alperozturk96 wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −0
Open

fix(thumbnail): generation for zip file #17171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,9 @@ private Bitmap doThumbnailFromOCFileInBackground() {
String imageKey = PREFIX_THUMBNAIL + file.getRemoteId();

boolean updateEnforced = (file instanceof OCFile && ((OCFile) file).isUpdateThumbnailNeeded());
if (MimeTypeUtil.isZip(file)) {
return null;
}

// Try to load thumbnail from disk cache
if (!updateEnforced) {
Expand Down
21 changes: 21 additions & 0 deletions app/src/main/java/com/owncloud/android/utils/MimeTypeUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,27 @@ public static boolean isPDF(OCFile file) {
return isPDF(file.getMimeType()) || isPDF(getMimeTypeFromPath(file.getRemotePath()));
}

public static boolean isZip(String mimeType) {
if (mimeType == null) {
return false;
}
String lower = mimeType.toLowerCase(Locale.ROOT);
return lower.equals("application/zip")
|| lower.equals("application/x-7z-compressed")
|| lower.equals("application/x-bzip2")
|| lower.equals("application/x-compressed")
|| lower.equals("application/x-deb")
|| lower.equals("application/gzip")
|| lower.equals("application/x-gzip")
|| lower.equals("application/x-rar-compressed")
|| lower.equals("application/x-tar")
|| lower.equals("application/vnd.android.package-archive");
}

public static boolean isZip(ServerFileInterface file) {
return isZip(file.getMimeType());
}

/**
* Extracts the mime type for the given file.
*
Expand Down
Loading