refactor(AccountForm): do not delete password errors manually#1775
Closed
edward-ly wants to merge 3 commits into
Closed
refactor(AccountForm): do not delete password errors manually#1775edward-ly wants to merge 3 commits into
edward-ly wants to merge 3 commits into
Conversation
This resolves an incompatibility with Python 3.14 where manipulating the Django forms `_errors` property directly is considered unsafe. Assisted-by: Copilot:gpt-5.4 Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
fix/noid/account-form-error
branch
from
3e4314e to
52e59c3
Compare
…licitly Assisted-by: Copilot:gpt-5.4 Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
fix/noid/account-form-error
branch
from
0158cac to
9e2115c
Compare
Collaborator
Author
|
Never mind, it turns out Django 4.2.x does not support Python versions higher than 3.12 (ref). If we want to upgrade Python or Django later, we'll need to do both at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an incompatibility with Python 3.14 where manipulating the Django forms
_errorsproperty directly is considered unsafe.Assisted-by: Copilot:gpt-5.4