fix: show the content of the dashboard widget again - #243
Merged
Merged
Conversation
The widget showed only its connect button to users without a GitHub account: - NcEmptyContent no longer has the title prop the message was passed in, so the message was never shown. It now uses the name prop. - /notifications requested the GitHub API without a token for such users and answered 401, so the widget reported an error. It now answers 400, which the widget already treats as not connected, without calling GitHub. darkThemeColor was not used anywhere and read OCA.Accessibility, which Nextcloud no longer provides, so it is removed. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub dashboard widget shows only its Connect to GitHub button to users who did not connect a GitHub account, and greets them with a Failed to get GitHub notifications error.
The empty content message is shown
The message was passed to
NcEmptyContentin atitleprop, which the component no longer has, so it only ended up as the tooltip of the element. It now uses thenameprop.Users without a GitHub account are asked to connect one
GET /notificationsrequested the GitHub API without a token for these users and answered 401 with the error it got back, so the widget showed an error toast and its error state. When the user has no token, it now answers 400 without calling GitHub, which the widget already treats as not connected.darkThemeColor, which read the long goneOCA.Accessibility, was not used and is removed.馃 AI (if applicable)