test: cover the link preview widgets and the search providers - #247
Merged
Merged
Conversation
CI builds the frontend but never runs it, and the pages the suite visits so far never load the reference bundle, so a dependency update that breaks a link preview still passes with every check green. The new tests load that bundle the way Nextcloud does wherever a link preview is rendered, render each widget of the app from a fixed rich object, and check that the app offers its providers to the smart picker and to unified search and that a search answers an empty result for a user who has connected no account. The server container also gets ten minutes to start instead of five, after a run failed on a slow runner while the container was still booting. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Playwright suite visits the settings pages and the dashboard widget, and neither of them loads the reference bundle, the part of the frontend that renders link previews. A dependency update that breaks that bundle still passes with every check green.
The reference widgets are rendered in a browser
The tests load the reference bundle the same way Nextcloud does wherever a link preview appears, then render each widget of the app from a fixed rich object in the shape the app's own reference provider builds, and check what the widget shows. Nothing leaves the container, so no account and no API key are needed.
The providers have to answer for a user without an account
The tests check that the app offers its providers to the smart picker and to unified search with the expected titles, that the provider icons are served by the app, and that a search answers an empty result instead of an error when no account is connected.
The server gets longer to start
A Playwright run failed this week because the shallow server container was still booting after five minutes, so the suite waits ten minutes for it now.
馃 AI (if applicable)