test: cover the page that closes the authentication popup - #153
Merged
Merged
Conversation
The popup page is the one frontend of the app that no test loaded, and CI builds the frontend without running it, so a dependency update could break the end of the OAuth flow with every check green. The new test opens the page with a user name, pretends to be the window that opened it, and expects the name to arrive in the message the bundle posts back. The server container also gets ten minutes to start instead of five, after a run failed on a slow runner while the container was still booting. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page that ends the OAuth flow loads its own bundle, and no test opened it, so a dependency update could break the last step of connecting an account with every check green.
The popup page is covered
The test opens the page with a user name, pretends to be the window that opened it, and expects that name to arrive in the message the bundle posts back before it closes the popup.
The server gets longer to start
A Playwright run failed this week because the shallow server container was still booting after five minutes, so the suite waits ten minutes for it now.
馃 AI (if applicable)