fix: say when an import stops before it is finished - #156
Merged
Merged
Conversation
oleksandr-nc
force-pushed
the
fix/139/say-when-an-import-stops
branch
from
September 25, 2026 08:06
475c71f to
a8b9f9a
Compare
oleksandr-nc
force-pushed
the
fix/139/come-back-for-unfinished-pages
branch
3 times, most recently
from
September 25, 2026 10:47
9e7905a to
b431d4e
Compare
Base automatically changed from
fix/139/come-back-for-unfinished-pages
to
main
September 25, 2026 10:56
oleksandr-nc
force-pushed
the
fix/139/say-when-an-import-stops
branch
from
September 25, 2026 10:58
a8b9f9a to
2ca9417
Compare
An import that could not read the drive, or whose job threw, reset its flags and ended: no notification, and nothing in the log either, so the only sign left was that the import had stopped moving. It now writes the reason to the log and sends a notification saying the import stopped, with what it had imported so far. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
The stub answers the drive itself with a revoked consent once the test asks it to, which is what an import that stops before it is finished looks like from the app. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
fix/139/say-when-an-import-stops
branch
from
September 25, 2026 11:52
2ca9417 to
e8eacad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #139, after #155: an import that ends before it has seen the whole drive used to end in silence.
What happened
Every batch starts by asking for the drive, to know its size. That answer is not used for anything — the line that read it is commented out — but when the request fails,
importFiles()returns the error, the job resets the import flags and stops. No notification is sent, because only a finished import sends one, and the error was never written to the log either. The same held for anything thrown inside the import: the message was put into a string and dropped.What the user saw was an import that was running and now is not, with nothing anywhere to say why. This is what happened to the second import of the CI job in #144, on a request that came back with an error from Microsoft.
What changes
__toString().What this does not cover
A folder the API refuses to list is dropped from the import, and the import still reports itself as finished. That path needs the finished state to be derived from the import tree, with a bounded number of retries, which is a change of its own.
Where it is covered
The stubbed Graph API answers the drive with a revoked consent once the test asks it to, and the job checks that the import gives up, that the only notification left is this one with the right body, and that the log says why.