chore: migrate to @nextcloud/eslint-config 9 - #157
Open
oleksandr-nc wants to merge 1 commit into
Open
oleksandr-nc wants to merge 1 commit into
oleksandr-nc wants to merge 1 commit into
Conversation
Its ESLint 10 reads a flat config only, so .eslintrc.js becomes eslint.config.mjs and eslint-webpack-plugin, whose 5.x releases accept ESLint 9 at most, moves to 6 and is told that the config is flat. The import rules are gone from the shared config, so 'import/extensions' goes with them, as do the babel parser options and the appVersion global the sources do not use. 'no-console' was built into the old config and is now spelled out. The sources follow what the new rules ask for: sorted imports, blank lines between multi line component options, camel cased attributes and events in templates, and no unused response arguments. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nextcloud/eslint-config9 brings ESLint 10, which reads a flat config only and ignores.eslintrc.*.The config
.eslintrc.jsbecomeseslint.config.mjs, spreadingrecommendedJavascriptbecause the components here are plain JavaScript. The overrides that still exist are kept,no-consoleis spelled out because the old config had it built in, and three things are dropped:import/extensions, since the shared config no longer ships eslint-plugin-import, the babel parser options, and theappVersionglobal the sources never use.The webpack plugin
eslint-webpack-plugin5.x accepts ESLint 9 at most, so it moves to 6, andconfigTypebecomesflat.The sources
What the new rules ask for, which
eslint --fixapplied: imports sorted, blank lines between multi line component options, attributes and events camel cased in templates, and the unusedresponsearguments of promise callbacks removed. Two warnings remain and do not fail the build, both older than this change: a deprecatedOC.dialogscall and an undeclaredclickemit.