refactor(NavigationManager): move navigation definitions into apps#60458
Open
susnux wants to merge 3 commits into
Open
refactor(NavigationManager): move navigation definitions into apps#60458susnux wants to merge 3 commits into
susnux wants to merge 3 commits into
Conversation
susnux
added
3. to review
susnux
force-pushed
the
refactor/navigation-manager
branch
2 times, most recently
from
07e7726 to
ebb1e3f
Compare
susnux
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
provokateurin
and removed request for
a team
susnux
force-pushed
the
refactor/navigation-manager
branch
2 times, most recently
from
e94945b to
33914a2
Compare
| } | ||
|
|
||
| foreach ($apps as $app) { | ||
| if (!$this->userSession->isLoggedIn() && !$this->appManager->isEnabledForUser($app, $this->userSession->getUser())) { |
Member
There was a problem hiding this comment.
I see why this is necessary now, but doesn't this lead to exposing apps to the user that they shouldn't be able to see?
Contributor
Author
There was a problem hiding this comment.
See line 207-211 its basically already handled because $app is set already to enabled apps for that user
The manager itself does not need to know what hardcoded-things an app provides, instead the apps itself should handle this. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/navigation-manager
branch
from
33914a2 to
2b2c21f
Compare
Contributor
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The manager itself does not need to know what hardcoded-things an app provides, instead the apps itself should handle this.
Adds a bit more separation between apps business logic and the core Nextcloud backend.
Checklist
3. to review, feature component)stable32)AI (if applicable)