Skip to content

fix(caldav-delegation): send notification to delegator#60712

Open
hamza221 wants to merge 1 commit into
masterfrom
fix/caldav-delegation/notifications
Open

fix(caldav-delegation): send notification to delegator#60712
hamza221 wants to merge 1 commit into
masterfrom
fix/caldav-delegation/notifications

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented May 24, 2026 •
edited
Loading

Summary

Sends notifications to delegator for actions taken on his behalf by delegate

Create update move/delete restore permenant deletion
image image image image image

Testing

Should work out of the box but :
If you need the frontend checkout

If you need trashbin:

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@hamza221 hamza221 mentioned this pull request May 24, 2026
Closed
8 tasks
@hamza221 hamza221 added 2. developing Work in progress feature: caldav Related to CalDAV internals enhancement labels May 24, 2026
@hamza221 hamza221 modified the milestones: Nextcloud 34, Nextcloud 35 May 24, 2026
@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 24, 2026

/backport to stable34

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 24, 2026

/backport to stable33

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 24, 2026

/backport to stable32

@hamza221 hamza221 mentioned this pull request May 24, 2026
Open
10 tasks
@hamza221 hamza221 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 24, 2026
@hamza221 hamza221 marked this pull request as ready for review May 24, 2026 13:07
@hamza221 hamza221 requested review from ArtificialOwl, CarlSchwan, leftybournes and provokateurin and removed request for a team May 24, 2026 13:08
@hamza221 hamza221 force-pushed the fix/caldav-delegation/notifications branch from a2d4fe7 to d9aec9b Compare May 24, 2026 13:11
@hamza221 hamza221 self-assigned this May 24, 2026
SebastianKrupinski
SebastianKrupinski reviewed May 24, 2026
View reviewed changes
Comment thread apps/dav/lib/CalDAV/Schedule/DelegateActionContext.php Outdated
Comment thread apps/dav/lib/Listener/CalendarDelegateActionListener.php Outdated
GVodyanov
GVodyanov reviewed May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The designs look really nice, but do you need a mail server to test this? I can't get it to work but I think that's just my instance being buggy

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 25, 2026 •
edited
Loading

The designs look really nice, but do you need a mail server to test this? I can't get it to work but I think that's just my instance being buggy

The delegator needs to have an email address setup in his profile (so he can receive an email)

If you're using https://github.com/juliusknorr/nextcloud-docker-dev/ , just go to mail.local to see the messages,
If not you have to setup an actual mail server and email addresses that you have access to

GVodyanov
GVodyanov approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks nice!

@hamza221
fix(caldav-delegation): send notification to delegator
6f3d0a9 
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the fix/caldav-delegation/notifications branch from d9aec9b to 6f3d0a9 Compare May 28, 2026 11:17
SebastianKrupinski
SebastianKrupinski approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 28, 2026

/backport to stable34

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 28, 2026

/backport to stable33

@hamza221
Copy link
Copy Markdown
Contributor Author

hamza221 commented May 28, 2026

/backport to stable32

SebastianKrupinski
SebastianKrupinski reviewed May 28, 2026
View reviewed changes
Comment thread apps/dav/lib/CalDAV/CalDavBackend.php
Comment on lines +1493 to +1501
$objectRow = array_merge($oldObjectRow, [
'uid' => $extraData['uid'],
'lastmodified' => $lastModified,
'etag' => '"' . $extraData['etag'] . '"',
'size' => (int)$extraData['size'],
'calendardata' => $calendarData,
'component' => strtolower($extraData['componentType']),
'classification' => (int)$extraData['classification'],
]);
Copy link
Copy Markdown
Contributor

@SebastianKrupinski SebastianKrupinski May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing I noticed, the normalized data also has lastoccurance and firstoccurance, these two fields also need to be transferred, so that if the dates change they are up to date

Copy link
Copy Markdown
Contributor Author

@hamza221 hamza221 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped because https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/CalDavBackend.php#L1273-L1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@GVodyanov GVodyanov GVodyanov approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

Assignees

@hamza221 hamza221

Labels

3. to review Waiting for reviews backport-request enhancement feature: caldav Related to CalDAV internals

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

3 participants

@hamza221 @GVodyanov @SebastianKrupinski