Skip to content

[stable-33.0] [master] 2003-Account_Settings_Dialog#433

Open
github-actions[bot] wants to merge 23 commits into
stable-33.0from
backport/nmc/390/stable-33.0
Open

[stable-33.0] [master] 2003-Account_Settings_Dialog#433
github-actions[bot] wants to merge 23 commits into
stable-33.0from
backport/nmc/390/stable-33.0

fix

cd41f90
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 9, 2026 in 7m 31s

Annotations

Check failure on line 80 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6NBs3l10gqRWuLZuoQ&open=AZ6NBs3l10gqRWuLZuoQ&pullRequest=433

Check failure on line 137 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the code so that you no longer need this "delete".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6IXfqjJ7ouI5WEW9W2&open=AZ6IXfqjJ7ouI5WEW9W2&pullRequest=433

Check warning on line 344 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6NBs3l10gqRWuLZuoR&open=AZ6NBs3l10gqRWuLZuoR&pullRequest=433

Check failure on line 41 in src/gui/nmcgui/nmcaccountsettings.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ5kjKUBsG1uv08ofyYq&open=AZ5kjKUBsG1uv08ofyYq&pullRequest=433

Check failure on line 36 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6D2dwQ6nhd5cS8Um45&open=AZ6D2dwQ6nhd5cS8Um45&pullRequest=433

Check warning on line 41 in src/gui/nmcgui/nmcaccountsettings.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ5kjKUBsG1uv08ofyYr&open=AZ5kjKUBsG1uv08ofyYr&pullRequest=433

Check failure on line 210 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 28 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6NiYiFoYoPD6IQoqOA&open=AZ6NiYiFoYoPD6IQoqOA&pullRequest=433

Check failure on line 226 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6IXfqjJ7ouI5WEW9W0&open=AZ6IXfqjJ7ouI5WEW9W0&pullRequest=433

Check failure on line 291 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the code so that you no longer need this "delete".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6IXfqjJ7ouI5WEW9W3&open=AZ6IXfqjJ7ouI5WEW9W3&pullRequest=433

Check warning on line 265 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 36 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6NiYiFoYoPD6IQoqOB&open=AZ6NiYiFoYoPD6IQoqOB&pullRequest=433

Check warning on line 167 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "layout" is "class QLayout *".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ6NTCyYtFB1JmYaqa_N&open=AZ6NTCyYtFB1JmYaqa_N&pullRequest=433