Skip to content

Users/mjohanse/new timing fields#333

Draft
mjohanse-emr wants to merge 5 commits into
mainfrom
users/mjohanse/new_timing_fields
Draft

Users/mjohanse/new timing fields#333
mjohanse-emr wants to merge 5 commits into
mainfrom
users/mjohanse/new_timing_fields

Conversation

@mjohanse-emr
Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

Updates the waveform conversion functions to handle the following new timing fields:

  • timestamp
  • time_offset
  • timestamps

Unit tests have been added to test conversion cases specific to these parameters.
Existing unit tests have been updated where necessary (example, don't expect and exception for irregular timing anymore).

Why should this Pull Request be merged?

To establish parity between our python API and our C# API.
To allow users to publish Irregular Timing waveforms and "Relative Timing" waveforms.

What testing has been done?

Many new tests have been added that were inspired by the C# auto tests.
Existing waveform conversion tests are passing.

… fix existing tests.

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

  119 files   -   1    119 suites   - 1   3m 24s ⏱️ +2s
  283 tests + 32    281 ✅ + 32   2 💤 ±0  0 ❌ ±0 
2 828 runs  +318  2 800 ✅ +320  28 💤  - 2  0 ❌ ±0 

Results for commit 2a7d797. ± Comparison against base commit 0b84363.

This pull request removes 5 and adds 37 tests. Note that renamed tests count towards both.
tests.unit.test_waveform_conversion ‑ test___analog_waveform_with_irregular_timing___convert___raises_value_error
tests.unit.test_waveform_conversion ‑ test___digital_waveform_round_trip___convert___valid_protobuf
tests.unit.test_waveform_conversion ‑ test___float64_complex_waveform_with_irregular_timing___convert___raises_value_error
tests.unit.test_waveform_conversion ‑ test___int16_analog_waveform_with_irregular_timing___convert___raises_value_error
tests.unit.test_waveform_conversion ‑ test___int16_complex_waveform_with_irregular_timing___convert___raises_value_error
tests.unit.test_waveform_conversion ‑ test___analog_waveform_with_irregular_timing___convert___valid_protobuf
tests.unit.test_waveform_conversion ‑ test___analog_waveform_with_none_timing___round_trip___waveforms_match
tests.unit.test_waveform_conversion ‑ test___analog_waveform_with_standard_timing___round_trip___waveforms_match
tests.unit.test_waveform_conversion ‑ test___analog_waveform_with_standard_timing_and_offset___convert___valid_protobuf
tests.unit.test_waveform_conversion ‑ test___dbl_analog_wfm_with_dt_and_offset___convert___valid_python_object
tests.unit.test_waveform_conversion ‑ test___dbl_analog_wfm_with_t0_and_offset_no_timestamp___convert___raises_exception
tests.unit.test_waveform_conversion ‑ test___dbl_analog_wfm_with_t0_and_timestamp_and_offset___convert___valid_python_object
tests.unit.test_waveform_conversion ‑ test___dbl_analog_wfm_with_timing___round_trip___waveforms_match
tests.unit.test_waveform_conversion ‑ test___dbl_complex_wfm_with_dt_and_offset___convert___valid_python_object
tests.unit.test_waveform_conversion ‑ test___dbl_complex_wfm_with_t0_and_offset_no_timestamp___convert___raises_exception
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant