Simple UDP Implementation - #27
Open
GregoryFan wants to merge 14 commits into
Open
Conversation
This reverts commit 819040f.
Chenxy517
requested changes
Aug 19, 2025
Chenxy517
left a comment
Chenxy517
left a comment
Contributor
There was a problem hiding this comment.
Please see the comments. UDP receiver should not be blocked even sender sends nothing.
| addXmitBytes(sent); | ||
| } | ||
|
|
||
| std::string CommSocketUDP::commRecv(unsigned long numBytes) { |
Contributor
There was a problem hiding this comment.
Maybe consider adding a timout mechanism in case sender does not send anything and block the commRecv function.
Contributor
Author
|
I've added a timeout function for the commRecv such that the function will stop and continue running the rest of the process if no data is sent within the specified amount of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a subclass of
Communicantthat uses UDP protocol instead of the TCP protocol in other Communicants. This implementation is simple and as such does not include checks for packet reliability nor for packet orderliness.