chore(deps): declare 3 direct imports Knip flagged as unlisted - #779
Conversation
npm run knip:deps (tuned in #773) reports 3 unlisted-dependency findings — all genuinely imported, just missing from package.json because they were only ever resolved transitively: - @radix-ui/react-compose-refs — imported directly by Fairway's tabs component (src/components/fairway/controls/tabs.tsx). - fflate — imported directly by the Baseball XLSX/PDF stat-import adapters (src/lib/baseball/adapters/{xlsx,pdf}-reader.ts). - postcss-load-config — referenced as a JSDoc type import in postcss.config.mjs (devDependency: build-time only, not runtime). Verified via grep before adding (all three have real, non-test production usages except the type-only postcss-load-config import). Versions pinned to what npm already resolves transitively today, so this is a manifest correction, not a version bump. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Summary by CodeRabbit
Walkthroughpackage.json:88, 120, and 169 add three new dependency entries: ChangesDependency additions
Estimated code review effort: 1 (Trivial) | ~3 minutes Related issues: None specified in the provided diff. Related PRs: None specified in the provided diff. Suggested labels: dependencies Suggested reviewers: None specified — assign based on package ownership for package.json:88 — verify No sequence diagram generated — this PR is a config/dependency-only change with no control flow to visualize. Poem
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.0)ast-grep could not parse rule config: /ast-grep-rules/../git/.coderabbit/ast-grep/no-explicit-any.yml Comment |
PR Summary by QodoDeclare Knip-unlisted direct dependencies in package.json
AI Description
High-Level Assessment
Files changed (1)
|
Summary
Phase 10 of the HelmV3 stabilization brief.
npm run knip:deps(tuned in #773) reports 3 unlisted-dependency findings — all genuinely imported, just missing frompackage.jsonbecause they were only ever resolved transitively.@radix-ui/react-compose-refs— imported directly by Fairway's tabs component (src/components/fairway/controls/tabs.tsx).fflate— imported directly by the Baseball XLSX/PDF stat-import adapters (src/lib/baseball/adapters/{xlsx,pdf}-reader.ts).postcss-load-config— referenced as a JSDoc type import inpostcss.config.mjs(added as a devDependency: build-time type only, not runtime).Verified via grep before adding — all three have real usages. Versions pinned to what npm already resolves transitively today, so this is a manifest correction, not a version bump.
Test plan
npm run typecheck— clean.npm run test:run— 428 files / 4398 passed, 39 skipped (unchanged frommain).npm run build— succeeds.Made with Cursor