Slice 1: topology.json v0 schema types (#7) - #14
Merged
Merged
Conversation
Curated-generous snapshot model designed from real scanned data:
- ENI stores raw ownership signals (attachment/description/interfaceType);
logical-resource classification deferred to the aggregation layer
- Routes normalized to {destination, target, state}; unknown targets preserved
- SG rules flattened to atomic {direction, protocol, ports, peer}
- Arrays + schemaVersion envelope; tags as maps; vpcEndpoints included
Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7. The
topology.jsonv0 schema — the contract betweenscanand render/explain/diff — designed from the real testenv dump.Decisions (see
internal/topology/doc.go)attachment(instanceId/instanceOwnerId/requesterId/requesterManaged) +interfaceType+description; classifying an ENI to its logical resource (instance/ALB/RDS/endpoint) is a heuristic, so it lives in the aggregation layer, not the snapshot.{destination{kind,value}, target{kind,id}, state}— deterministic union; unmapped targets →TargetUnknown(flagged honestly, not dropped).{direction, protocol, fromPort, toPort, peer{kind,value}}— the rung-1 engine`s evaluation unit.schemaVersion; tags asmap[string]string; IPv6 stored not reasoned;vpcEndpointsincluded.Follow-ups (not this PR)
DescribeVpcEndpointsto the scanner.Verified
go build,go vet,golangci-lintall clean.