fix(ci): scope npm audit gate to production dependencies - #137
Merged
Conversation
GHSA-mh99-v99m-4gvg (brace-expansion <=5.0.7, high, DoS) is pulled in via minimatch@3 by eslint 9 and eslint-config-next's plugin chain. The only patched version (5.0.8) breaks minimatch@3 consumers and no 1.x backport exists, so the dev tree cannot be cleaned until upstream moves off minimatch@3. Production dependencies audit clean (0 findings). Scope the audit gate to --omit=dev so dev-only advisories stop blocking every PR; revert once upstream ships patched releases. Closes #136 Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Ronny Trommer <ronny@no42.org>
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
GHSA-mh99-v99m-4gvg (brace-expansion <=5.0.7, high, DoS) blocks the
npm audit --audit-level=highstep inmake verifyon all open Dependabot PRs (#132–#135) and would block the next push to main.The advisory is unfixable in the dev tree today: the only patched version (5.0.8) breaks minimatch@3 (
TypeError: expand is not a function— verified locally), and eslint 9 plus eslint-config-next's plugin chain (all published versions) require minimatch@3 → brace-expansion ^1, which has no backport.Production dependencies are unaffected:
npm audit --omit=dev --audit-level=high→ 0 vulnerabilities.This scopes the
audittarget and theverifyaudit step to--omit=dev, with a Makefile comment referencing the advisory. Revert once upstream ships releases off minimatch@3.Verification:
make verifypasses locally (lint + typecheck + tests + scoped audit + build, exit 0).🤖 Generated with Claude Code