src: remove TOCTOU race condition when encoding SAB-backed Buffers

[aduh95]

If the BufferView is backed by a SharedArrayBuffer, we want to copy the content before passing it to String::Encode in case the data is mutated in a different thread.

Otherwise the validate_utf8 and convert_valid_utf8_to_utf16 might get bytes, leading to undefined behavior

node/src/string_bytes.cc

Lines 585 to 600 in e209dbe

	if (buflen >= 32 && simdutf::validate_utf8(buf, buflen)) {
	// We know that we are non-ASCII (and are unlikely Latin1), use 2-byte
	// In the most likely case of valid UTF-8, we can use this fast impl
	// For very short input, it is slower, so we limit min size
	size_t u16size = simdutf::utf16_length_from_utf8(buf, buflen);
	if (u16size > static_cast<size_t>(v8::String::kMaxLength)) {
	isolate->ThrowException(ERR_STRING_TOO_LONG(isolate));
	return MaybeLocal<Value>();
	}
	return EncodeTwoByteString(
	isolate, u16size, [buf, buflen, u16size](uint16_t* dst) {
	size_t written = simdutf::convert_valid_utf8_to_utf16(
	buf, buflen, reinterpret_cast<char16_t*>(dst));
	CHECK_EQ(written, u16size);
	});
	}

Refs: https://hackerone.com/reports/3752489

[codecov]

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (ca37665) to head (ac48f30).
⚠️ Report is 73 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_buffer.cc	60.00%	0 Missing and 6 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63517      +/-   ##
==========================================
+ Coverage   90.12%   90.30%   +0.18%     
==========================================
  Files         718      730      +12     
  Lines      227911   234690    +6779     
  Branches    42813    43946    +1133     
==========================================
+ Hits       205404   211936    +6532     
- Misses      14288    14473     +185     
- Partials     8219     8281      +62     

Files with missing lines	Coverage Δ
src/encoding_binding.cc	54.08% <100.00%> (+1.16%)	⬆️
src/node_buffer.cc	68.64% <60.00%> (+0.17%)	⬆️

... and 123 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73642/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73737/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73761/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73791/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73796/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73802/

[aduh95]

Landed in 17e4196