Skip to content

build: fix missing symbol error in debug build#63768

Open
bnoordhuis wants to merge 1 commit into
nodejs:mainfrom
bnoordhuis:fix-debug-build
Open

build: fix missing symbol error in debug build#63768
bnoordhuis wants to merge 1 commit into
nodejs:mainfrom
bnoordhuis:fix-debug-build

Conversation

@bnoordhuis

Copy link
Copy Markdown
Member

Link in a dummy BuiltinCanAllocate, otherwise the link step fails with a missing symbol error in debug builds.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Jun 6, 2026
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Link in a dummy BuiltinCanAllocate, otherwise the link step fails with a
missing symbol error in debug builds.

Signed-off-by: Ben Noordhuis <info@bnoordhuis.nl>
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 21, 2026
@richardlau

Copy link
Copy Markdown
Member

This is failing the debug builds
e.g. https://ci.nodejs.org/job/node-test-commit-arm-debug/24449/nodes=ubuntu2404_debug-arm64/console

08:03:13 /usr/bin/ld: /home/iojs/build/workspace/node-test-commit-arm-debug/out/Release/obj.target/v8_snapshot/geni/src/builtins/builtins-effects.o: in function `v8::internal::BuiltinCanAllocate(v8::internal::Builtin)':
08:03:13 builtins-effects.cc:(.text._ZN2v88internal18BuiltinCanAllocateENS0_7BuiltinE+0x0): multiple definition of `v8::internal::BuiltinCanAllocate(v8::internal::Builtin)'; /home/iojs/build/workspace/node-test-commit-arm-debug/out/Release/obj.target/v8_snapshot/deps/v8/src/snapshot/builtins-effects-dummy.o:builtins-effects-dummy.cc:(.text._ZN2v88internal18BuiltinCanAllocateENS0_7BuiltinE+0x0): first defined here
08:03:16 clang++-19: error: linker command failed with exit code 1 (use -v to see invocation)
08:03:16 make[2]: *** [node_mksnapshot.target.mk:323: /home/iojs/build/workspace/node-test-commit-arm-debug/out/Release/node_mksnapshot] Error 1
08:03:16 rm 299b117ee6c63671c7cddffdb3bb82acec04ba1258d84980bc48fc55c5364b23.intermediate 4b0390c6bfc63f31136e8b246546e95bd95f3fb1bca71edd2ff14b819ff1e445.intermediate 46c8a2d1294b28c7686eac0cf2fb5c91d46303cfbef8522f44c60bfb96a3da53.intermediate 8297d7c8140d776d5957c1c4857cf6e687f763cc8ba6ac87b8766732520b9e34.intermediate 2929ef1dccc9aca55bd7302ffddfc5a40cd27a6d06e2d374d94ce6d646fc0776.intermediate
08:03:16 make[1]: *** [Makefile:143: node] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants