sqlite: keep database alive while a session is open

[3zrv]

fixes: #63796

Verification

• Repro crashes (SIGSEGV, exit 139) before the change; throws ERR_INVALID_STATE after.
• New regression test fails (segfault) on an unfixed build and passes on the fixed build.
• Full test/parallel/test-sqlite-session.js suite passes (26/26).

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[louwers]

I think a session is supposed to keep the database alive...

[3zrv]

@louwers totally right, the bug was that the session held the database with a weak ref, so it could get GC'd out from under a live session -> dangling pointer -> crash. sqlite requires sessions to be deleted before the connection closes, so a live session with a dead DB is never valid

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (34c28d5) to head (f6b4960).
⚠️ Report is 44 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63797      +/-   ##
==========================================
- Coverage   90.23%   90.14%   -0.10%     
==========================================
  Files         739      741       +2     
  Lines      241639   241978     +339     
  Branches    45547    45538       -9     
==========================================
+ Hits       218031   218119      +88     
- Misses      15152    15374     +222     
- Partials     8456     8485      +29     

Files with missing lines	Coverage Δ
src/node_sqlite.h	80.64% <ø> (ø)
src/node_sqlite.cc	80.65% <25.00%> (-0.06%)	⬇️

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74960/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/63797
✔  Done loading data for nodejs/node/pull/63797
----------------------------------- PR info ------------------------------------
Title      sqlite: keep database alive while a session is open (#63797)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     3zrv:fix/sqlite-session-crash -> nodejs:main
Labels     c++, author ready, needs-ci, commit-queue-squash, sqlite
Commits    3
 - sqlite: fix crash when a session outlives its database
 - fix: keep database alive while a session is open
 - Merge branch 'main' into fix/sqlite-session-crash
Committers 1
 - Mohamed Sayed <k@3zrv.com>
PR-URL: https://github.com/nodejs/node/pull/63797
Fixes: https://github.com/nodejs/node/issues/63796
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63797
Fixes: https://github.com/nodejs/node/issues/63796
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 08 Jun 2026 16:23:46 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63797#pullrequestreview-4731067200
   ✔  - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/63797#pullrequestreview-4744533536
   ⚠  GitHub cannot link the author of 'sqlite: fix crash when a session outlives its database' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ⚠  GitHub cannot link the author of 'fix: keep database alive while a session is open' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ⚠  GitHub cannot link the author of 'Merge branch 'main' into fix/sqlite-session-crash' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-07-21T12:30:19Z: https://ci.nodejs.org/job/node-test-pull-request/74960/
- Querying data for job/node-test-pull-request/74960/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 63797
From https://github.com/nodejs/node
 * branch                  refs/pull/63797/merge -> FETCH_HEAD
✔  Fetched commits as 69e982f70d31..f6b496025e59
--------------------------------------------------------------------------------
Auto-merging src/node_sqlite.cc
Auto-merging test/parallel/test-sqlite-session.js
[main ed54edc94a] sqlite: fix crash when a session outlives its database
 Author: Mohamed Sayed <k@3zrv.com>
 Date: Mon Jun 8 19:21:31 2026 +0300
 2 files changed, 35 insertions(+), 3 deletions(-)
Auto-merging src/node_sqlite.cc
Auto-merging test/parallel/test-sqlite-session.js
error: commit f6b496025e5974385c8adea13857b5fd7d810171 is a merge but no -m option was given.
fatal: cherry-pick failed
[main aca4f7c47a] fix: keep database alive while a session is open Signed-off-by: Mohamed Sayed <k@3zrv.com>
 Author: Mohamed Sayed <k@3zrv.com>
 Date: Mon Jun 8 20:26:15 2026 +0300
 3 files changed, 31 insertions(+), 31 deletions(-)
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/29837964050