vfs: follow symlinked dirs in recursive mkdir#64287
Merged
nodejs-github-bot merged 1 commit intoJul 7, 2026
Merged
Conversation
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Jul 4, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Recursive mkdir currently checks an existing intermediate entry directly, so a symlink to a directory is treated as a non-directory and throws ENOTDIR. Resolve symlinked intermediate components while walking the recursive mkdir path, creating new directories in the resolved target while preserving the caller-facing first-created return path. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
vfs-recursive-mkdir-symlink
branch
from
0d2b3d5 to
60174cd
Compare
Member
Author
mcollina
added
request-ci
This comment was marked as low quality.
This comment was marked as low quality.
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d3be8ab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64286
Fix recursive
mkdirinnode:vfsso symlinked intermediatedirectories are followed, matching native
fsbehavior.The change preserves the caller-facing return value for the first
created path while creating directories in the resolved symlink target.
Assisted-by: openai:gpt-5.5