Skip to content

deps: update ngtcp2 to 1.24.0#64297

Merged
nodejs-github-bot merged 3 commits into
mainfrom
actions/truetools-update-ngtcp2
Jul 11, 2026
Merged

deps: update ngtcp2 to 1.24.0#64297
nodejs-github-bot merged 3 commits into
mainfrom
actions/truetools-update-ngtcp2

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

This is an automated update of ngtcp2 to 1.24.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jul 5, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/quic
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 5, 2026
@aduh95

aduh95 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor 
../src/quic/session.cc:1659:48: error: missing field 'recv_stop_sending' initializer [-Werror,-Wmissing-field-initializers]
 1659 |       ngtcp2_crypto_get_path_challenge_data2_cb};
      |                                                ^
../src/quic/session.cc:1706:48: error: missing field 'recv_stop_sending' initializer [-Werror,-Wmissing-field-initializers]
 1706 |       ngtcp2_crypto_get_path_challenge_data2_cb};
      |                                                ^
2 errors generated.

@Renegade334 Renegade334 force-pushed the actions/truetools-update-ngtcp2 branch from febfe53 to f7712ae Compare July 6, 2026 16:34
@Renegade334

Renegade334 commented Jul 6, 2026

Copy link
Copy Markdown
Member

Rebased onto cac1a9f.

@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/74605/

@aduh95 aduh95 requested a review from jasnell July 6, 2026 20:20
@Renegade334 Renegade334 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2026
aduh95
aduh95 approved these changes Jul 11, 2026
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2026
@nodejs-github-bot nodejs-github-bot merged commit 8a3b11c into main Jul 11, 2026
81 of 82 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator Author

Landed in 8a3b11c

@nodejs-github-bot nodejs-github-bot deleted the actions/truetools-update-ngtcp2 branch July 11, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterry pimterry pimterry approved these changes
@aduh95 aduh95 aduh95 approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nodejs-github-bot @aduh95 @Renegade334 @pimterry