-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
doc: allow deprecations while a release is Current #64387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcollina
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
mcollina:doc-deprecation-cycle-current
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -539,12 +539,18 @@ example, due to removal of an End-of-Life deprecated API). | |
|
|
||
| <a id="deprecation-cycle"></a> | ||
| A _deprecation cycle_ is a major release during which an API has been in one of | ||
| the three Deprecation levels. Documentation-Only Deprecations can land in a | ||
| minor release. They can not change to a Runtime Deprecation until the next major | ||
| release. | ||
| the three Deprecation levels. A deprecation can be added to a release line at | ||
| any point while that release line is Current, but not once it has entered the | ||
| Active LTS or Maintenance phases. A deprecation added while a major release is | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those phases are going away, Node.js 27 won't have "Active LTS" not "Maintenance" phases |
||
| Current counts as a deprecation cycle for that release: the API can change to | ||
| the next deprecation level in the following major release. Documentation-Only | ||
| Deprecations can land in a minor release. They can not change to a Runtime | ||
| Deprecation until the next major release. | ||
|
|
||
| No deprecated APIs can change to End-of-Life without going through a Runtime | ||
| Deprecation cycle. There is no rule that deprecated code must progress to End-of-Life. | ||
| Deprecation cycle. An API that received a Runtime Deprecation while a major | ||
| release was Current can be removed (End-of-Life) in the following major | ||
| release. There is no rule that deprecated code must progress to End-of-Life. | ||
| Documentation-Only and Runtime Deprecations can remain in place for an unlimited | ||
| duration. | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely not a patch, however?