feat: Remove unused free() methods#91
Open
timfish wants to merge 1 commit into
Open
Conversation
timfish
changed the title
free() methods
isaacs
approved these changes
Jul 9, 2026
isaacs
left a comment
isaacs
left a comment
Contributor
There was a problem hiding this comment.
I guess it's worth leaving the no-ops in the lib code, just to not be backwards-incompatible?
LGTM
jsumners-nr
approved these changes
Jul 9, 2026
jsumners-nr
left a comment
jsumners-nr
left a comment
Contributor
There was a problem hiding this comment.
I am hesitant to actually remove the method. Somewhere in the conversations about the rewrite it was stated that the Rust WASM build could potentially come back as another module at some point. And research I have recently started, and paused, would also very likely need it. But, since the changed file isn't the actual implementation, this PR should be okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are only in the public API because they were required in the previous wasm version of this library.