Add Resolution pin to QuadMerge, deprecate LayoutQuadCanvas - #64
Open
atkurtul wants to merge 3 commits into
Open
Add Resolution pin to QuadMerge, deprecate LayoutQuadCanvas#64atkurtul wants to merge 3 commits into
atkurtul wants to merge 3 commits into
Conversation
Output is now unscaled and sized from the pin, following BoxFit.
Quad Merge covers the same 2x2 case in a single node. Still creatable. Also renames the inner Array (1) node to OutputInfos.
The node is not hidden from the menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quad Merge already did 2x2 composition in a single node, but had no way to set its output resolution. It now has a
Resolutionpin and an unscaled output, following the BoxFit pattern — the quadrant math stays declarative inQuadMerge.frag, and a small node class sizes the output.With that, Quad Merge covers what Layout Quad Canvas was for, so Layout Quad Canvas is marked
(Deprecated)in the menu and on the node, with a description pointing at the replacement. It stays creatable and existing graphs keep working — flippinghide_in_context_menucloses the door later. Its innerArray (1)node is renamed toOutputInfos.No class rename mapping: the pin names differ (
Input 0vsInput0,resolutionvsResolution) and onlyGetRenamedNodeClassesexists, no pin-rename hook, so a mapping would orphan every connection.Note for reviewers:
QuadMerge.cppis a new source file and this plugin's generated target does not glob withCONFIGURE_DEPENDS, so a plain build fails withLNK2019: unresolved external symbol RegisterQuadMergeuntil CMake is reconfigured.Not yet verified in the editor — compiles and links, but the Resolution pin resizing the output has not been confirmed at runtime.