Conversation
There was a problem hiding this comment.
Pull request overview
Syncs EFCore.PG to EF Core 11.0.0-preview.4.26210.110, aligning dependencies, adapting provider code to EF’s updated JSON path representation, and updating/adding functional tests to match new EF behaviors and baselines.
Changes:
- Bumps EF Core + Microsoft.Extensions package versions and updates the pinned .NET SDK.
- Updates
NpgsqlUpdateSqlGeneratorto work with EF’s new structuredJsonPathtype for JSON partial updates. - Updates JSON SQL baselines and adds a new navigation bulk update test class for new EF coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/EFCore.PG.FunctionalTests/Query/JsonQueryNpgsqlTest.cs | Updates SQL baselines to match EF’s revised JSON recordset/type-shape output. |
| test/EFCore.PG.FunctionalTests/Query/Associations/OwnedJson/OwnedJsonCollectionNpgsqlTest.cs | Updates owned-JSON association baselines (recordset column definitions reduced). |
| test/EFCore.PG.FunctionalTests/Query/Associations/Navigations/NavigationsBulkUpdateNpgsqlTest.cs | Adds a new provider-specific bulk update test class (EF base added upstream). |
| src/EFCore.PG/Update/Internal/NpgsqlUpdateSqlGenerator.cs | Adapts JSON partial update SQL generation to EF’s structured JsonPath. |
| global.json | Pins repo SDK to 11.0.100-preview.4.26210.111 to match updated dependency assembly versions. |
| Directory.Packages.props | Updates EF Core + Microsoft.Extensions package versions to preview.4.26210.110. |
roji
force-pushed
the
roji/sync-to-latest-ef
branch
from
d149870 to
3d7e3b5
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roji
force-pushed
the
roji/sync-to-latest-ef
branch
from
3d7e3b5 to
f76ddae
Compare
There was a problem hiding this comment.
Pull request overview
Syncs EFCore.PG to EF Core 11.0.0-preview.4.26210.110, updating dependency versions and adapting provider/test code to upstream EF changes (notably structured JsonPath and new bulk update navigation tests).
Changes:
- Bumped EF Core + Microsoft.Extensions package versions and updated the pinned .NET SDK in
global.json. - Updated
NpgsqlUpdateSqlGeneratorto work with EF’s new structuredJsonPathrepresentation for JSON partial updates. - Updated JSON SQL baselines and added a new
NavigationsBulkUpdateNpgsqlTestclass to align with upstream relational test coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/EFCore.PG.FunctionalTests/Query/JsonQueryNpgsqlTest.cs | Updates SQL baselines for JSON collection queries (recordset column definitions / aliases). |
| test/EFCore.PG.FunctionalTests/Query/Associations/OwnedJson/OwnedJsonCollectionNpgsqlTest.cs | Updates SQL baselines for owned JSON collection association tests. |
| test/EFCore.PG.FunctionalTests/Query/Associations/Navigations/NavigationsBulkUpdateNpgsqlTest.cs | Adds new navigation bulk update test class aligned with EF relational base tests and PG-specific expectations. |
| src/EFCore.PG/Update/Internal/NpgsqlUpdateSqlGenerator.cs | Adapts JSON partial update SQL generation to structured JsonPath segments/ordinals. |
| global.json | Pins .NET SDK to a newer preview required by updated EF dependencies. |
| Directory.Packages.props | Bumps EFCore and Microsoft.Extensions package versions to the new preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the EF Core dependency from
11.0.0-preview.4.26203.108to11.0.0-preview.4.26210.110.Changes
11.0.100-preview.4.26210.111(required due to assembly version mismatch — new EF references DI.Abstractions 11.0.0.0)JsonPathtype (wasstring)jsonb_to_recordsettype definitions)NavigationsBulkUpdateRelationalTestBaseEF Core PRs requiring changes
NavigationsBulkUpdateRelationalTestBase)