Fix generateApiChanges diffing the empty root package instead of .any - #16
Merged
Merged
Conversation
The plain "assembly-rewriter" package id is a DotnetToolSettings.xml v2 shim that maps RIDs to per-RID sub-packages (see generatePackages) - it ships no managed assembly of its own, so diffing against it finds 0 assemblies. This would have broken "Inspect public API changes" on the next release, the same way it just did in release-notes: https://github.com/nullean/release-notes/actions/runs/33674817669/job/100397363448 The portable, signed managed build lives in "assembly-rewriter.any" instead; point previous-nuget at that. Co-authored-by: Cursor <cursoragent@cursor.com>
assembly-rewriter.any doesn't exist on nuget.org yet - the 0.14.0 release that would have published it failed before reaching the nuget push, so this next release is effectively the first one under that package id. Without -a/--allow-empty-previous-nuget, generateApiChanges treats "0 previous packages found" as a hard failure. Verified locally. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This landed on the
fix/proc-version-and-release-notes-clibranch but that PR (#15) auto-merged before this commit was pushed (its first commit's CI happened to pass, since the previous release it diffed against predated the AOT packaging rewrite). Re-landing it here as its own PR so it's in master before cutting0.14.1to complete the failed0.14.0release.The plain
assembly-rewriterpackage id is a DotnetToolSettings.xml v2 shim that maps RIDs to per-RID sub-packages - it ships no managed assembly of its own, so diffing against it finds 0 assemblies and failsInspect public API changes. Same bug already fixed inassembly-differ/release-notes/nupkg-validator. Pointsprevious-nugetatassembly-rewriter.anyinstead.Test plan
dotnet build build/scripts/scripts.fsproj -c Releasesucceeds.Made with Cursor