Retry dotnet tool restore once on a cold-cache failure - #86
Merged
Merged
Conversation
dotnet/sdk#53783: restoring 2+ RID-specific tool packages in one manifest (release-notes, nupkg-validator, assembly-differ are all native-AOT now) can misattribute one package's DotnetToolSettings.xml to another on a cold tool-resolver cache - every fresh CI runner hits this. The cache is warm after the first attempt, so a bare retry always succeeds. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet tool restorenow retries once on failure: dotnet/sdk#53783 causes cold-cache restores of 2+ RID-specific tool packages in one manifest (release-notes,nupkg-validator,assembly-differare all native-AOT now) to misattribute one package'sDotnetToolSettings.xmlto another - hit on every fresh CI runner or fresh container, before the resolver cache warms up. Found while chasing down the same failure inassembly-differ/assembly-rewriter/nupkg-validator's own release pipelines.Test plan
dotnet build build/scripts/scripts.fsproj -c Releasesucceeds.Made with Cursor