Conversation
…hange; the Share panel counts pictures still uploading
Build size
Updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slides side of #509, stacked on
kernel-snap-assets(retargets to main once #509 merges).syncNoticeText: atoo-largenotice withsnapshot: true(kernel's field for a refused whole-deck snapshot, which matches no op of ours) is worded "This deck is too large to share live in one piece. Your changes are saved in your copy, but a collaborator joining now may not receive the whole deck." — before themediabranch; the change and image wordings are unchanged. After kernel: a relay snapshot strips large inline assets (photo-heavy decks share again) #509 a snapshot carries no inline pictures, so this now means the deck's own text/tables/small assets exceed the relay's frame ceiling (a comment says so).session.pendingBlobUploads() > 0— informational, stated in the code.pendingBlobUploads()polled once a second only while the popover is open (the interval stops itself when the wrap closes; a rebuild clears the previous poll), hidden at 0, singular/plural via the existing key pattern, only while sharing is on.scripts/test-slides-sync-notice.ts21/21, registered in CI (snapshotbeforemedia; the kernel type is used, not widened; the poll's open-only lifecycle; every new string in all 8 core catalogs); 5 strings × 30 catalogs, coverage 100%; ci-registered 359; typecheck; build 653 KB.2 pictures still uploading…/ de2 Bilder werden noch hochgeladen…). The popover line and the toast could not be driven live: the session instance is not reachable from the page (window.bento.syncis a facade) and turning sharing on reaches the real relay — their behaviour is source-pinned by the rig instead.