CUST-5289 [v3] Python SDK ListGrantsQueryParams uses camelCase keys t…#464
Open
samLRodrigues wants to merge 2 commits intomainfrom
Conversation
…hat are silently ignored by the API License I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner. Fix ListGrantsQueryParams key handling in Python SDK - Fix bug where `sortBy`, `orderBy`, and `grantStatus` are sent as-is and ignored by the API. - Normalize grants query aliases to `sort_by`, `order_by`, and `grant_status` at request serialization time. - Align type hints with snake_case API contract while keeping camelCase aliases for backwards compatibility. - Preserve existing SDK behavior for callers already using snake_case keys. ✅ Tests checks: - `pytest tests/handler/test_http_client.py -k test_build_query_params -q` (100%) - Manual serialization check for grants aliases via `_build_query_params` (verified) Made-with: Cursor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9ff6150. Configure here.
pengfeiye
approved these changes
Apr 13, 2026
Contributor
pengfeiye
left a comment
pengfeiye
left a comment
There was a problem hiding this comment.
LGTM fix cursor sugesstion
Move camelCase-to-snake_case key normalization out of the shared HTTP query builder and into the grants resource so only grants list parameters are transformed. Add grants-specific tests to verify camelCase compatibility and snake_case precedence. Made-with: Cursor
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Fix ListGrantsQueryParams key handling in Python SDK
sortBy,orderBy, andgrantStatusare sent as-is and ignored by the API.sort_by,order_by, andgrant_statusat request serialization time.✅ Tests checks:
pytest tests/handler/test_http_client.py -k test_build_query_params -q(100%)_build_query_params(verified)Note
Low Risk
Low risk: small, targeted change to query-string serialization and type hints; behavior only differs when callers pass the affected camelCase keys, which now map to the API-expected snake_case names.
Overview
Fixes a bug where
ListGrantsQueryParamscamelCase keys (sortBy,orderBy,grantStatus) were serialized as-is and ignored by the API by normalizing them tosort_by,order_by, andgrant_statusinsidehttp_client._build_query_params.Updates
ListGrantsQueryParamstyping/docs to prefer snake_case keys while keeping the camelCase fields as deprecated, backward-compatible aliases.Reviewed by Cursor Bugbot for commit 9ff6150. Bugbot is set up for automated code reviews on this repo. Configure here.