test(provin): stop packing @o3co/auth.utils, pin Provin at its auth.utils-free develop - #28
Merged
Merged
Conversation
…tils-free develop Provin's scaffolds stopped emitting @o3co/auth.utils in provin-line/auth#22 (develop 74e22644): the create-provider and create-policy-verifier templates now ship their own logger and shutdown, the same way auth.provider (#290), auth.proxy (#81) and auth.policy-verifier (#210) do. That was the package's last consumer across the family, so the harness no longer needs to pack it, pin its revision, or carry the lockfile snapshot that stood in for the one its repo does not track. The override list is back to the five Provider/Verifier packages. The provin-compatibility job on this PR is the cross-repo check: Provin at the new pin, built and tested against the candidate auth tarballs, with no utils override to fall back on. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently remove the auth.utils pin/override path across the runner, Makefile, and docs without leaving any remaining references or broken steps.
Pull request overview
This PR updates the Provin compatibility E2E harness to fully remove the last remaining @o3co/auth.utils fallback by dropping the utils repo pin/pack/install steps and repinning Provin to a commit that no longer emits @o3co/auth.utils in its scaffolds. This fits the repo’s purpose as cross-component integration/E2E coverage by ensuring the downstream consumer build is exercised only against the candidate Provider/Verifier tarballs.
Changes:
- Bump
PROVIN_REVto74e22644…(Provin develop after provin-line/auth#22). - Remove
auth.utilscloning/building and the pnpm override/packing entry from the Provin compatibility runner. - Delete the now-unused
tests/provin/auth-utils.pnpm-lock.yamland update Provin test README accordingly.
File summaries
| File | Description |
|---|---|
| tests/provin/run.mjs | Removes packing/override of auth.utils, leaving only Provider/Verifier packages to be packed and overridden in Provin’s consumer install. |
| tests/provin/README.md | Updates documentation to reflect that only the five Provider/Verifier packages are packed/overridden (no utils step). |
| tests/provin/auth-utils.pnpm-lock.yaml | Deletes the utils-only lockfile snapshot since utils is no longer cloned/installed. |
| Makefile | Drops UTILS_REV and the utils clone/install/build steps; repins Provin to the new revision. |
Review details
Files not reviewed (1)
- tests/provin/auth-utils.pnpm-lock.yaml: Generated file
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to provin-line/auth#22, which stopped both Provin scaffolds from emitting
@o3co/auth.utils— the package's last consumer across the auth family (auth.provider left in #290, auth.proxy in #81, auth.policy-verifier in #210).Changes
PROVIN_REV→74e22644(Provin develop after docs: describe auth.provider as it is — no DID login, and the id+jwt window is closed #22).UTILS_REV, theauth.utilsclone, its install/build step, and the["auth.utils", "."]override entry are removed. The override list is back to the five Provider/Verifier packages.tests/provin/auth-utils.pnpm-lock.yamlis deleted: it existed only because the utils repo tracks no lockfile, and nothing is installed from it any more.tests/provin/README.mdno longer describes the utils step.What this PR proves
provin-compatibilityon this run builds Provin at the new pin against the candidate auth tarballs with no utils override to fall back on. If the scaffolds still reached for@o3co/auth.utilsanywhere, the consumer install would resolve it from npm (0.0.4) and the test would still pass silently — so the run passing is necessary but not the whole story; the emittedpackage.jsonassertion in Provin's own generator suite (#22) is what pins the absence.🤖 Generated with Claude Code