test: drop the Provin compatibility job — a downstream consumer's checks are its own - #35
Merged
Merged
Conversation
…cks are its own #26 added a CI job that packs the pinned provider and verifier builds and runs provin-line/auth's source, DID grant, collectors and generated composition roots against them, pinned here as PROVIN_REV. That puts one named consumer inside the auth family's release gate: every documented BREAKING change turns the release-cut pin PR red until that consumer catches up, as the v0.10.0 verifier cut did (Provin's tests held evaluate() unawaited). The auth family is independent of any consumer. What it owes one is generic extension points — custom grants, collectors, module wiring — and those are tested in the component repos and by this repository's E2E without naming a consumer. Checking that a particular consumer builds against a new auth release, and adapting it, belongs to that consumer's repository. Removes the provin-compatibility job, PROVIN_REV and the setup-provin / test-provin targets, tests/provin, and the paragraph in docs/internal-adoption.md that pointed at it. test-e2e is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain, and the changes consistently remove the consumer-specific gate.
Pull request overview
Removes the consumer-specific Provin compatibility gate while preserving generic E2E coverage.
Changes:
- Removes the Provin CI job and Makefile targets.
- Deletes the Provin compatibility harness and documentation.
- Removes the obsolete adoption reference.
- Preserves
test-e2e.
File summaries
| File | Description |
|---|---|
tests/provin/run.mjs |
Deletes the Provin test runner. |
tests/provin/README.md |
Deletes compatibility documentation. |
Makefile |
Removes Provin targets and revision. |
docs/internal-adoption.md |
Removes the Provin reference. |
.github/workflows/e2e.yml |
Removes the Provin CI job. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#26 added
provin-compatibility: a CI job that packs the pinned provider and verifier builds and runsprovin-line/auth(pinned asPROVIN_REV) against them — its DID grant, collectors and generated composition roots. That puts one named consumer inside the auth family's release gate. Every documented BREAKING change turns the release-cut pin PR red until that consumer catches up; #34 did exactly that, because Provin's tests held the now-asynchronousevaluate()(o3co/auth.policy-verifier#240) unawaited.The auth family is independent of any consumer. What it owes a consumer is generic extension points (custom grants, collectors, module wiring). Those are tested in the component repositories and by this repository's E2E, without naming a consumer. Checking that a particular consumer builds against a new auth release, and adapting it, belongs to that consumer's repository.
Removed:
provin-compatibilityjob in.github/workflows/e2e.ymlPROVIN_REVand thesetup-provin/test-provintargets inMakefiletests/provin/docs/internal-adoption.mdthat pointed at ittest-e2eis unchanged.Test plan
git grep -i -w -E "provin|dplaax|test-provin|PROVIN_REV"returns nothingmake -n setupparses;e2e.ymlparses as YAMLtest-e2egreen🤖 Generated with Claude Code