port: existing snippets to MacOS#10
Open
PhantomCloak wants to merge 2 commits into
Open
Conversation
Signed-off-by: PhantomCloak <unalozyurtrooter@hotmail.com>
Signed-off-by: PhantomCloak <unalozyurtrooter@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports the existing PhysX snippets to MacOS. I tested these changes on my M1 Mac, where all snippets ran successfully without any issues further feedbacks & validations are welcome.
Key changes
Werrorflag has been taken out from the compiler options, for MacOS due to several warnings found in the source code while trying to compile on clang since these warning not within scope of this PR making this change will solve the issue with minimal impact.GLFontRenderer::init -> glGenTextures(1, (GLuint*)&m_textureObject);.physx/snippets/compiler/cmake/mac