Guard MSVC-specific __m128 field access from clang#14
Open
EnterTheArcane wants to merge 1 commit into
Open
Conversation
Signed-off-by: EnterTheArcane <96613937+EnterTheArcane@users.noreply.github.com>
EnterTheArcane
force-pushed
the
release/104.1
branch
from
63483e7 to
2ac0ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes build failures when compiling PhysX with clang and clang-cl on Windows.
Several functions in
PxWindowsInlineAoS.haccess__m128through MSVC-specific union members such asm128_u16andm128_u32, e.g.:This works with MSVC because its headers expose
__m128as a union-like type with named members. However, clang treats__m128as a builtin vector type rather than a struct/union, so member access is not supported. As a result, it emits errors like:Changes
The affected functions that rely on MSVC-only
__m128member access are now excluded when compiling under clang:The excluded functions are not used by O3DE, so conditionally compiling them out under clang is a safe and minimal fix. This avoids introducing more invasive changes, such as rewriting the implementations to use portable intrinsics or alternative vector types.