Skip to content

Fix properties types#575

Open
SYNchroACK wants to merge 4 commits into
oasis-open:masterfrom
SYNchroACK:fix/properties_types
Open

Fix properties types#575
SYNchroACK wants to merge 4 commits into
oasis-open:masterfrom
SYNchroACK:fix/properties_types

Conversation

@SYNchroACK

Copy link
Copy Markdown
  • Rename properties types based on the naming pattern
  • Add missing _type field

@rpiazza

rpiazza commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

@chisholm - is this worth merging?

@chisholm

Copy link
Copy Markdown
Contributor

In principle, I am okay with what the changes are doing. But this doesn't appear to change type names in enough places. For example, see imports in:

from .observables import (
URL, AlternateDataStream, ArchiveExt, Artifact, AutonomousSystem,
CustomObservable, Directory, DomainName, EmailAddress, EmailMessage,
EmailMIMEComponent, File, HTTPRequestExt, ICMPExt, IPv4Address,
IPv6Address, MACAddress, Mutex, NetworkTraffic, NTFSExt, PDFExt, Process,
RasterImageExt, SocketExt, Software, TCPExt, UNIXAccountExt, UserAccount,
WindowsPEBinaryExt, WindowsPEOptionalHeaderType, WindowsPESection,
WindowsProcessExt, WindowsRegistryKey, WindowsRegistryValueType,
WindowsServiceExt, X509Certificate, X509V3ExtensionsType,
)

This change breaks some of those imports. Perhaps an IDE should be used to do the refactor, to ensure the names are changed in all places they are used.

@CLAassistant

CLAassistant commented Jul 31, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants