fix: preserve desktop MCP OAuth consent through login#208
Open
oshtz wants to merge 1 commit into
Open
Conversation
oshtz
marked this pull request as ready for review
July 24, 2026 14:39
Member
|
cool |
oshtz
force-pushed
the
agent/fix-desktop-mcp-oauth
branch
from
July 24, 2026 18:48
0449de2 to
96e8fcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
Summary
Current
mainnow advertises the packaged desktop app's dynamic API and dashboard origins correctly. One part of the MCP OAuth flow remains broken in zero-auth mode: creating the local session drops the pending consent return path, and/mcp/authorizeis not accepted by the existing safereturnToallowlist.This change:
/api/auth/desktop-loginand back through the dashboard's existing redirect validator/mcp/authorizein the safe relative-path allowlist while continuing to reject external redirectsThe branch is rebased on current
mainand leaves itsOPENSHIP_ADVERTISED_ORIGINimplementation unchanged.Testing
returnTovalues remain rejected