chore: ignore build artifacts from deploy fixtures#245
Open
walidozich wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.gitignorerules for the build artifacts that running the deploy fixtures leaves behind, so they stop showing up as untracked files.Motivation
Building the fixtures under
fixtures/deploy/(for example to test a .NET or Kotlin deploy) leaves toolchain output in the working tree.git statusthen reports untracked directories that are pure build output, which is noise during review and easy to commit by accident.Observed on a clean checkout after exercising the fixtures:
The existing
# Build outputsblock coversdist/,.next/,.turbo/, andout/, but nothing for the .NET or Gradle fixtures.Related issue
None. Small self-contained improvement, which CONTRIBUTING.md allows as a direct PR.
Changes
.gitignore: ignoreobj/,bin/,.gradle/, andbuild/underfixtures/deploy/*/only.obj/and.gradle/are the two I directly observed.bin/andbuild/are the sibling outputs the same two toolchains emit (dotnet writesbin/alongsideobj/; Gradle writesbuild/alongside.gradle/), included so the same report does not recur.Why these are scoped to
fixtures/deploy/*/A bare
build/orbin/rule would also matchapps/desktop/build/andapps/cli/build/, which are tracked source directories, not output. Scoping the rules to the fixtures avoids shadowing them. There is a comment in the file recording this so the next person does not widen the pattern.Verification
The rules match the actual artifacts:
No tracked file is shadowed by the new rules:
The tracked build directories stay visible, which is the specific risk of a broader pattern:
Checklist
bun run test,bun run --cwd <workspace> lint, andbun formatall pass locallyNote on the test checkbox:
.gitignorerules are not unit-testable, so thegit check-ignoreoutput above is the equivalent evidence, including the negative case proving tracked sources are not caught.