Conversation
Author
|
Additional real-data validation: I launched this branch under the pinned Node 24.21.0 runtime against the existing 3.4 GB episodic-memory database (without changing the installed plugin). MCP initialize/list, populated text search, embedding-backed vector search, and archive read all passed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
better-sqlite3from 12.x to^13.0.3, whose bundled N-API binaries work across Node module ABIsvec_version()to a real vec0 insert and nearest-neighbor queryFailure reproduced
On macOS arm64 with Node 24.21.0, rebuilding
better-sqlite312.11.1 from source and then runningtest/integration.test.tsdeterministically aborted inStatement::~Statement()/RemoveEnvironmentCleanupHookduring V8 garbage collection. This matches nodejs/node#65446 and the downstream reproduction in tobi/qmd#827.The old 12.x binding is also ABI-specific, which is why rebuilding it under Node 26 makes it unloadable under Node 24. Version 13 moved to N-API in WiseLibs/better-sqlite3#1498 and avoids both failure modes.
Validation
npm installnative vector probe passed with better-sqlite3 13.0.3npm run buildpassednode_moduleswithout a rebuild: native vector probe passedThe test now fails if text or vector search returns no result, not merely if the MCP call avoids throwing.